-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding command LMove
#319
Adding command LMove
#319
Conversation
0d9ebf6
to
d7069a1
Compare
* @param destination The key to the destination list. | ||
* @param wherefrom The direction the element should be removed from. | ||
* @param whereto The direction the element should be added to. | ||
* @return The popped element or null. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @return The popped element or null. | |
* @return The popped element or <code>null</code>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... or null
in which case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when source
doesnt exist it returns null, should that be included in the javadoc?
If source does not exist, the value nil is returned and no operation is performed.
https://redis.io/docs/latest/commands/lmove/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in commit c618bad
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/ListDirection.java
Outdated
Show resolved
Hide resolved
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
* Adding command `LMove` (#319) * Adding command LMove --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com> * addressing review comments * undo renaming of the lmpop arguments * spotless --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com>
* Adding command `LMove` (#319) * Adding command LMove --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com> * addressing review comments * undo renaming of the lmpop arguments * spotless --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com>
Add command LMove